Messages in this thread | | | Date | Thu, 18 Aug 2022 18:15:06 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] kernel: move from strlcpy with unused retval to strscpy |
| |
On Thu, 18 Aug 2022 23:02:01 +0200 Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Grumble.
"So it's a completely useless function if you can't implicitly trust the source string - but that is almost always why people think they should use it!"
But in my cases I actually do trust the source string. They are all generated from the kernel (not user input). With the exception of the trace_inject, which I didn't write, and that should definitely be converted.
But eh, I'm not going to argue this one.
-- Steve
| |