lkml.org 
[lkml]   [2022]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: move from strlcpy with unused retval to strscpy
From
Date
On 8/18/22 3:01 PM, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>

Please elaborate and summarize why this change makses sense in the
commit log? It will be easier for reviewers - saves time checking
the link.

> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/usb/atm/usbatm.c | 2 +-
> drivers/usb/core/devio.c | 2 +-
> drivers/usb/gadget/function/f_fs.c | 2 +-
> drivers/usb/gadget/function/f_uvc.c | 2 +-
> drivers/usb/gadget/function/u_ether.c | 8 ++++----
> drivers/usb/gadget/function/uvc_v4l2.c | 6 +++---
> drivers/usb/gadget/udc/omap_udc.c | 2 +-
> drivers/usb/misc/usb251xb.c | 6 +++---
> drivers/usb/storage/onetouch.c | 2 +-
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> drivers/usb/usbip/stub_main.c | 2 +-

I don't have any problems with the change itself. I would ike to
see the commit log clealrly state why this change is good. With
that for usbip change:

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah

\
 
 \ /
  Last update: 2022-08-18 23:27    [W:0.086 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site