lkml.org 
[lkml]   [2022]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v2 13/16] hwmon: (mr75203) add thermal coefficient properties for Moortec PVT controller
    On Wed, Aug 17, 2022 at 05:43:18AM +0000, Eliav Farber wrote:
    > Add optional "ts-coeff-g", "ts-coeff-h", "ts-coeff-cal5" and
    > "ts-coeff-j" properties to be used instead of defaults for the
    > thermal equasion.
    >
    Vendor prefix again, and shouldn;t there be some note about the
    to-be-used defaults ?

    Guenter

    > Signed-off-by: Eliav Farber <farbere@amazon.com>
    > ---
    > .../bindings/hwmon/moortec,mr75203.yaml | 33 +++++++++++++++++++
    > 1 file changed, 33 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
    > index e2a55001eefc..867664bd937f 100644
    > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
    > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
    > @@ -62,6 +62,30 @@ properties:
    > used to normalzie the voltage output results.
    > $ref: /schemas/types.yaml#definitions/uint32
    >
    > + ts-coeff-g:
    > + description:
    > + G coefficient for thermal equation.
    > + maxItems: 1
    > + $ref: /schemas/types.yaml#definitions/uint32
    > +
    > + ts-coeff-h:
    > + description:
    > + H coefficient for thermal equation.
    > + maxItems: 1
    > + $ref: /schemas/types.yaml#definitions/uint32
    > +
    > + ts-coeff-cal5:
    > + description:
    > + cal5 coefficient for thermal equation (can't be 0).
    > + maxItems: 1
    > + $ref: /schemas/types.yaml#definitions/uint32
    > +
    > + ts-coeff-j:
    > + description:
    > + J coefficient for thermal equation.
    > + maxItems: 1
    > + $ref: /schemas/types.yaml#definitions/int32
    > +
    > required:
    > - compatible
    > - reg
    > @@ -75,6 +99,10 @@ additionalProperties:
    > - reset-control-skip
    > - vm-active-channels
    > - vm-pre-scalar-ch#
    > + - ts-coeff-g
    > + - ts-coeff-h
    > + - ts-coeff-cal5
    > + - ts-coeff-j
    >
    > examples:
    > - |
    > @@ -90,5 +118,10 @@ examples:
    > resets = <&rcu0 0x40 7>;
    > vm-active-channels = [08 10 02];
    > vm-pre-scalar-ch5 = <2>;
    > + ts-coeff-g = <57400>;
    > + ts-coeff-h = <249400>;
    > + ts-coeff-cal5 = <4096>;
    > + ts-coeff-j = <0>;
    > +
    > #thermal-sensor-cells = <1>;
    > };

    \
     
     \ /
      Last update: 2022-08-18 22:26    [W:4.128 / U:1.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site