Messages in this thread | | | Subject | Re: [PATCH v2 03/16] hwmon: (mr75203) update Moortec PVT controller intel, vm-map property | Date | Thu, 18 Aug 2022 23:20:22 +0300 | From | "Farber, Eliav" <> |
| |
On 8/18/2022 10:47 PM, Guenter Roeck wrote: > Ah. This patch should come first, before making associated > code changes, and there would need to be an explanation > _why_ it is not a mandatory property. Also, some action > is taken in the previous patches if the property is not > there. That indicates that the driver is expected to > use some defaults if the property is indeed not provided, > and that expected default should be documented. Ack. I should have been more clear and explained that driver actually handles the case that "intel,vm-map" does not exist (including an explicit comment - "Incase intel,vm-map property is not defined ...") and that it is actually optional.
-- Regards, Eliav
| |