Messages in this thread | | | Date | Wed, 17 Aug 2022 08:18:54 -0600 | From | Keith Busch <> | Subject | Re: [RFC PATCH] nvmet-tcp: Don't kmap() pages which can't come from HIGHMEM |
| |
On Wed, Aug 17, 2022 at 12:44:09PM +0300, Sagi Grimberg wrote: > > > You should also remove the cmd's 'nr_mapped' field while you're at it, > > otherwise you'll hit the WARN in nvmet_tcp_free_cmd_buffers(). > > Not remove nr_mapped because we use it to know the iovec entries, but > we can just remove the WARN statement.
It's only used locally within nvmet_tcp_map_pdu_iovec() after this change, so no need to carry it in struct nvmet_tcp_cmd anymore.
| |