Messages in this thread Patch in this message | | | Date | Wed, 17 Aug 2022 13:42:42 -0000 | From | "irqchip-bot for Antonio Borneo" <> | Subject | [irqchip: irq/irqchip-fixes] irqchip/stm32-exti: Remove check on always false condition |
| |
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: c3e88d91e40971337d4e7b5250e9e17d3e64238c Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/c3e88d91e40971337d4e7b5250e9e17d3e64238c Author: Antonio Borneo <antonio.borneo@foss.st.com> AuthorDate: Wed, 17 Aug 2022 14:57:58 +02:00 Committer: Marc Zyngier <maz@kernel.org> CommitterDate: Wed, 17 Aug 2022 14:19:48 +01:00
irqchip/stm32-exti: Remove check on always false condition
The field drv_data is assigned during driver's probe, where it's already checked to be not NULL.
Remove the always false check '!host_data->drv_data'.
This fixes a warning "variable dereferenced before check" detected by '0-DAY CI Kernel Test Service'.
Fixes: c297493336b7 ("irqchip/stm32-exti: Simplify irq description table") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/lkml/202208131739.gJvcs9ls-lkp@intel.com/ Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220817125758.5975-1-antonio.borneo@foss.st.com --- drivers/irqchip/irq-stm32-exti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c index a73763d..6a3f749 100644 --- a/drivers/irqchip/irq-stm32-exti.c +++ b/drivers/irqchip/irq-stm32-exti.c @@ -716,7 +716,7 @@ static int stm32_exti_h_domain_alloc(struct irq_domain *dm, irq_domain_set_hwirq_and_chip(dm, virq, hwirq, chip, chip_data); - if (!host_data->drv_data || !host_data->drv_data->desc_irqs) + if (!host_data->drv_data->desc_irqs) return -EINVAL; desc_irq = host_data->drv_data->desc_irqs[hwirq];
| |