Messages in this thread | | | Date | Wed, 17 Aug 2022 13:43:07 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] drivers: binderfs: fix memory leak in binderfs_fill_super |
| |
On Mon, Aug 15, 2022 at 10:47:40AM +0200, Christian Brauner wrote: > On Mon, Aug 15, 2022 at 02:46:36AM +0100, Al Viro wrote: > > On Fri, Aug 12, 2022 at 04:32:28PM +0200, Greg Kroah-Hartman wrote: > > > > > > It's a bit tricky to follow but d_make_root() always consumes the inode. > > > > On success via d_instantiate() and on failure via iput(). So when > > > > d_make_root() has been called the inode is off limits. And as soon as > > > > d_make_root() has returned successfully we're guaranteed that > > > > sb->s_fs_info is cleaned up if a ->put_super() method has been defined. > > > > Just fyi. > > > > > > Ah, thanks, that wasn't obvious at all. > > > > > > greg k-h > > > > FWIW, I would rather provide a proper ->kill_sb() and gotten rid of > > all that stuff. The thing is, unlike ->put_super(), ->kill_sb() is > > called for *anything* that has gotten to foo_fill_super(). Usually > > allows to get rid of those "call all of or parts of foo_put_super() > > on failure exits" and associated bitrot... > > > > Like this (completely untested): > > > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> > > --- > > Sounds good, > Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
Looks much better to me too. Can someone (Christian?) turn this into a real patch that I can apply?
thanks,
greg k-h
| |