Messages in this thread | | | Date | Wed, 17 Aug 2022 09:58:03 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v3 3/5] x86/microcode: Avoid any chance of MCE's during microcode update |
| |
* Ingo Molnar <mingo@kernel.org> wrote:
> > +void mce_set_mcip(void) > > +{ > > + mce_wrmsrl(MSR_IA32_MCG_STATUS, 0x1); > > +} > > + > > +void mce_clear_mcip(void) > > +{ > > + mce_wrmsrl(MSR_IA32_MCG_STATUS, 0x0); > > +} > > Instead of naming new APIs after how they are doing stuff, please name them > after *what* they are doing at the highest level: they disable/enable MCEs. > > Ie. I'd suggest something like: > > mce_disable() > mce_enable() > > I'd also suggest to at minimum add a WARN_ON_ONCE() if MSR_IA32_MCG_STATUS > is already 1 when we disable it - because whoever wanted it disabled will > now be surprised by us enabling them again.
Also, Boris tells me that writing 0x0 to MSR_IA32_MCG_STATUS apparently shuts the platform down - which is not ideal...
Thanks,
Ingo
| |