Messages in this thread | | | Subject | Re: [PATCH -next] mtd/ftl: Fix memleak in ftl_add_mtd() | From | cuigaosheng <> | Date | Thu, 18 Aug 2022 09:31:20 +0800 |
| |
PING
在 2022/7/15 15:11, Gaosheng Cui 写道: > When add_mtd_blktrans_dev failed, partition's memory will be freed > by kfree, but there are some structure members that are allocated > for memory independently, such as partition->VirtualBlockMap, > partition->EUNInfo, partition->ZferInfo, and partition->bam_cache, > so kfree(partition) may cause memory leaks, using ftl_freepart(partition) > will fix it. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > --- > drivers/mtd/ftl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/ftl.c b/drivers/mtd/ftl.c > index f655d2905270..200271bdc7aa 100644 > --- a/drivers/mtd/ftl.c > +++ b/drivers/mtd/ftl.c > @@ -1031,6 +1031,7 @@ static void ftl_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) > partition->mbd.devnum = -1; > if (!add_mtd_blktrans_dev(&partition->mbd)) > return; > + ftl_freepart(partition); > } > > kfree(partition);
| |