lkml.org 
[lkml]   [2022]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove the dependency on ghes
    Date


    > -----Original Message-----
    > From: Borislav Petkov <bp@alien8.de>
    > Sent: Thursday, August 18, 2022 5:35 AM
    > To: Kani, Toshi <toshi.kani@hpe.com>
    > Cc: Justin He <Justin.He@arm.com>; Ard Biesheuvel <ardb@kernel.org>; Len
    > Brown <lenb@kernel.org>; James Morse <James.Morse@arm.com>; Tony
    > Luck <tony.luck@intel.com>; Mauro Carvalho Chehab
    > <mchehab@kernel.org>; Robert Richter <rric@kernel.org>; Robert Moore
    > <robert.moore@intel.com>; linux-acpi@vger.kernel.org;
    > linux-kernel@vger.kernel.org; linux-edac@vger.kernel.org; devel@acpica.org;
    > Rafael J . Wysocki <rafael@kernel.org>; Shuai Xue
    > <xueshuai@linux.alibaba.com>; Jarkko Sakkinen <jarkko@kernel.org>;
    > linux-efi@vger.kernel.org; nd <nd@arm.com>; stable@kernel.org
    > Subject: Re: [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove
    > the dependency on ghes
    >
    > On Wed, Aug 17, 2022 at 09:09:41PM +0000, Kani, Toshi wrote:
    > > Since then, the change below enabled ghes_edac on Arm without this
    > > known-good platforms check.
    > >
    > > commit eaa3a1d46 ("EDAC, ghes: Make platform-based whitelisting
    > > x86-only")
    >
    > Bah, I had forgotten about that one...
    >
    > In any case, edac_mc_add_mc* is too late in the init path - that check should
    > happen as the very first thing in the driver init function.
    >
    > And looking at the ARM64 EDAC drivers, they're only a couple: thunderx,
    > xgene, bluefield, dmc-520... And I'd still prefer if their maintainers explicitly
    > ACK such a change to call ghes_get_devices() (for a lack of a better idea) and
    > not enable ghes_edac on them blindly.
    Okay, will include above changes in next version, thanks for the reminder.

    --
    Cheers,
    Justin (Jia He)


    \
     
     \ /
      Last update: 2022-08-18 03:26    [W:2.477 / U:0.900 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site