Messages in this thread | | | From | Raul Rangel <> | Date | Wed, 17 Aug 2022 15:55:05 -0600 | Subject | Re: [PATCH v3] platform/chrome: cros_ec: Send host event for prepare/complete |
| |
LGTM
On Tue, Aug 2, 2022 at 11:40 AM Tim Van Patten <timvp@google.com> wrote: > > Update cros_ec_lpc_pm_ops to call cros_ec_lpc_prepare() during PM > .prepare() and cros_ec_lpc_complete() during .complete(). This allows the > EC to log entry/exit of AP's suspend/resume more accurately. > > Signed-off-by: Tim Van Patten <timvp@google.com> > --- > > Changes in v3: > - Update cros_ec_lpc_suspend() to cros_ec_lpc_prepare() > - Update cros_ec_lpc_resume() to cros_ec_lpc_complete() > > Changes in v2: > - Include cros_ec_resume() return value in dev_info() output. > - Guard setting .prepare/.complete with #ifdef CONFIG_PM_SLEEP. > > drivers/platform/chrome/cros_ec_lpc.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c > index 7677ab3c0ead9..4158bdeee197b 100644 > --- a/drivers/platform/chrome/cros_ec_lpc.c > +++ b/drivers/platform/chrome/cros_ec_lpc.c > @@ -530,23 +530,31 @@ static const struct dmi_system_id cros_ec_lpc_dmi_table[] __initconst = { > MODULE_DEVICE_TABLE(dmi, cros_ec_lpc_dmi_table); > > #ifdef CONFIG_PM_SLEEP > -static int cros_ec_lpc_suspend(struct device *dev) > +static int cros_ec_lpc_prepare(struct device *dev) > { > struct cros_ec_device *ec_dev = dev_get_drvdata(dev); > > + dev_info(dev, "Prepare EC suspend\n"); > + > return cros_ec_suspend(ec_dev); > } > > -static int cros_ec_lpc_resume(struct device *dev) > +static void cros_ec_lpc_complete(struct device *dev) > { > struct cros_ec_device *ec_dev = dev_get_drvdata(dev); > + int ret; > + > + ret = cros_ec_resume(ec_dev); > > - return cros_ec_resume(ec_dev); > + dev_info(dev, "EC resume completed: ret = %d\n", ret); > } > #endif > > static const struct dev_pm_ops cros_ec_lpc_pm_ops = { > - SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_lpc_suspend, cros_ec_lpc_resume) > +#ifdef CONFIG_PM_SLEEP > + .prepare = cros_ec_lpc_prepare, > + .complete = cros_ec_lpc_complete > +#endif > }; > > static struct platform_driver cros_ec_lpc_driver = { > -- > 2.37.1.455.g008518b4e5-goog >
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
| |