lkml.org 
[lkml]   [2022]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 linux-next] Remove Unnecessary TODO
From


On 8/16/22 19:59, Khalid Masum wrote:
> The capabilities enabled for multi-link are required as part of the
> programming sequences, even when a stream uses a single link we still
> use the syncArm/syncGo sequences. Therefore the TODO is no longer
> necessary.
>
> Suggested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>

the title of your patch should be something like

soundwire: intel: remove unnecessary TODO

so that the patch scope and context is clearly identified.
> ---
> Previous discussions:
> - v1 Link: https://lore.kernel.org/lkml/20220814080416.7531-1-khalid.masum.92@gmail.com/
>
> Changes since v1:
> - Remove the todo, leave rest of the code as is
> - Update commit message
>
> drivers/soundwire/bus.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
> index 8d4000664fa3..18158825a6d8 100644
> --- a/drivers/soundwire/bus.c
> +++ b/drivers/soundwire/bus.c
> @@ -75,7 +75,6 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent,
>
> /*
> * Initialize multi_link flag
> - * TODO: populate this flag by reading property from FW node
> */
> bus->multi_link = false;
> if (bus->ops->read_prop) {

\
 
 \ /
  Last update: 2022-08-17 08:33    [W:0.767 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site