Messages in this thread | | | Date | Wed, 17 Aug 2022 23:02:13 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded |
| |
On Wed, Aug 17, 2022 at 05:28:34PM -0300, Guilherme G. Piccoli wrote: > My understanding is the same as yours, i.e., this is not possible to > collect from vmcore, it requires register reading. But again: if you > kdump your machine today, you won't collect this information, patch > changed nothing in that regard.
Why won't you be able to collect it? You can certainly access dmesg in the vmcore and see those errors logged there.
> The one thing it changes is that you'd skip the altera register dump if > kdump is set AND you managed to also set "crash_kexec_post_notifiers".
What your patch changes is, it prevents s10_edac_dberr_handler() from logging potentially important fatal hw errors when kdump is loaded.
If Dinh is fine with that, I'll take the patch. But it looks like a bad idea to me.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |