lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0752/1157] usb: host: xhci: use snprintf() in xhci_decode_trb()
    Date
    From: Sergey Shtylyov <s.shtylyov@omp.ru>

    [ Upstream commit 1ce69c35b86038dd11d3a6115a04501c5b89a940 ]

    Commit cbf286e8ef83 ("xhci: fix unsafe memory usage in xhci tracing")
    apparently missed one sprintf() call in xhci_decode_trb() -- replace
    it with the snprintf() call as well...

    Found by Linux Verification Center (linuxtesting.org) with the SVACE static
    analysis tool.

    Fixes: cbf286e8ef83 ("xhci: fix unsafe memory usage in xhci tracing")
    Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
    Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
    Link: https://lore.kernel.org/r/20220630124645.1805902-2-mathias.nyman@linux.intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/host/xhci.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
    index 28aaf031f9a8..1960b47acfb2 100644
    --- a/drivers/usb/host/xhci.h
    +++ b/drivers/usb/host/xhci.h
    @@ -2417,7 +2417,7 @@ static inline const char *xhci_decode_trb(char *str, size_t size,
    field3 & TRB_CYCLE ? 'C' : 'c');
    break;
    case TRB_STOP_RING:
    - sprintf(str,
    + snprintf(str, size,
    "%s: slot %d sp %d ep %d flags %c",
    xhci_trb_type_string(type),
    TRB_TO_SLOT_ID(field3),
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:41    [W:4.019 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site