Messages in this thread | | | Date | Tue, 16 Aug 2022 14:12:25 +0300 | Subject | Re: [PATCH 06/12] riscv: dts: allwinner: Add the D1 SoC base devicetree | From | Krzysztof Kozlowski <> |
| |
On 16/08/2022 14:11, Krzysztof Kozlowski wrote: >> >> I think one reason might be that this is so central to the whole SoC >> operation, that it's already referenced multiple times in the base .dtsi. >> And having a yet unresolved reference in the .dtsi looks dodgy. >> >> NVidia seems to omit a base oscillator (maybe it's implicit in their >> binding design), Marvell doesn't use a fixed-clock (but still puts their >> base clock in armada-37xx.dtsi). >> >> Exynos and Renesas put a *stub* fixed-clock in the .dtsi, and set the >> frequency in the board .dts files. Would this be a compromise? > > This is exactly what I said before. The clock frequency is a property of > the board. Feel free to keep the rest of the clock in the SoC DTSI to > reduce duplication, but at minimum the clock should go to the board.
s/minimum the clock should go to the board/minimum the clock frequency should go to the board./
Best regards, Krzysztof
| |