Messages in this thread | | | Date | Tue, 16 Aug 2022 11:28:46 +0200 | Subject | Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32() | From | Cezary Rojewski <> |
| |
On 2022-08-09 5:23 PM, Andy Shevchenko wrote: > On Tue, Aug 9, 2022 at 11:55 AM Cezary Rojewski > <cezary.rojewski@intel.com> wrote:
...
> > I guess this may be simplified with memdup_user(). Otherwise it looks like that.
...
> (You don't use ppos here, so it's pointless to use > simple_write_to_buffer(), right? I have noticed this pattern in SOF > code, which might be simplified the same way as I suggested above)
Hello Andy,
Given the two major suggestions (memdup_user() and re-using get_options()) that had a major impact on the patch are both provided by you, would you like me to add any tags to the commit message? I'm speaking of Suggested-by or Co-developed-by and such. In you choose 'yes', please specify tags to be added.
By the way, I've provided 'the final form' on thesofproject/linux as PR [1] to see if no regression is caused in basic scenarios.
[1]: https://github.com/thesofproject/linux/pull/3812
Regards, Czarek
| |