Messages in this thread | | | From | Roberto Sassu <> | Subject | RE: [PATCH v10 5/9] bpf: Add bpf_lookup_*_key() and bpf_key_put() kfuncs | Date | Tue, 16 Aug 2022 08:40:14 +0000 |
| |
> From: KP Singh [mailto:kpsingh@kernel.org] > Sent: Friday, August 12, 2022 2:50 AM
[...]
> > +/** > > + * bpf_key_put - decrement key reference count if key is valid and free > bpf_key > > + * @bkey: bpf_key structure > > + * > > + * Decrement the reference count of the key inside *bkey*, if the pointer > > + * is valid, and free *bkey*. > > + */ > > This is more of a style thing but your comment literally describes the > small function > below. Do we really need this?
Thanks for the review, KP. Just kept this, to follow the style of kernel documentation for functions.
Roberto
| |