Messages in this thread Patch in this message | | | Date | Tue, 16 Aug 2022 05:12:37 +0000 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH v5 5/7] platform/chrome: cros_typec_switch: Register mode switches |
| |
On Mon, Aug 15, 2022 at 06:34:26AM +0000, Prashant Malani wrote: > Register mode switch devices for Type C connectors, when they are > specified by firmware. These control Type C configuration for any USB > Type-C mode switches (sometimes known as "muxes") which are controlled > by the Chrome EC.
To be consistent to the commit message, s/Type C/Type-C/g.
To be consistent to the series, I guess you would like to use ChromeOS instead of Chrome?
> @@ -235,6 +264,17 @@ static int cros_typec_register_switches(struct cros_typec_switch_data *sdata) > } > > dev_dbg(dev, "Retimer switch registered for index %llu\n", index); > + > + if (!fwnode_property_read_bool(fwnode, "mode-switch")) > + continue;
Would it be better to use device_property_present()?
| |