Messages in this thread | | | Date | Tue, 16 Aug 2022 12:15:38 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] workqueue: Fix memory ordering race in queue_work*() |
| |
Tejun Heo <tj@kernel.org> wrote: > > Oh, tricky one and yeah you're absolutely right that it makes no sense to > not guarantee barrier semantics when already pending. I didn't even know > test_and_set_bit() wasn't a barrier when it failed. Thanks a lot for hunting > down and fixing this. Applied to wq/for-6.0-fixes.
Please revert this as test_and_set_bit was always supposed to be a full memory barrier. This is an arch bug.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |