lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0604/1157] mtd: st_spi_fsm: Disable clock only after device was unregistered
    Date
    From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    [ Upstream commit cd043c613e21bb6f039057043da759471706adf5 ]

    Until mtd_device_unregister() returns the device is expected to be
    operational. So only disable the clock after the mtd is unregistered.

    Fixes: 1fefc8ecb834 ("mtd: st_spi_fsm: add missing clk_disable_unprepare() in stfsm_remove()")
    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/20220607152458.232847-4-u.kleine-koenig@pengutronix.de
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/devices/st_spi_fsm.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
    index a5a4b612480c..9f6d4dd8bade 100644
    --- a/drivers/mtd/devices/st_spi_fsm.c
    +++ b/drivers/mtd/devices/st_spi_fsm.c
    @@ -2128,10 +2128,10 @@ static int stfsm_remove(struct platform_device *pdev)
    {
    struct stfsm *fsm = platform_get_drvdata(pdev);

    - clk_disable_unprepare(fsm->clk);
    -
    WARN_ON(mtd_device_unregister(&fsm->mtd));

    + clk_disable_unprepare(fsm->clk);
    +
    return 0;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:34    [W:4.088 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site