lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0606/1157] fpga: altera-pr-ip: fix unsigned comparison with less than zero
    Date
    From: Marco Pagani <marpagan@redhat.com>

    [ Upstream commit 2df84a757d87fd62869fc401119d429735377ec5 ]

    Fix the "comparison with less than zero" warning reported by
    cppcheck for the unsigned (size_t) parameter count of the
    alt_pr_fpga_write() function.

    Fixes: d201cc17a8a3 ("fpga pr ip: Core driver support for Altera Partial Reconfiguration IP")
    Reviewed-by: Tom Rix <trix@redhat.com>
    Acked-by: Xu Yilun <yilun.xu@intel.com>
    Signed-off-by: Marco Pagani <marpagan@redhat.com>
    Link: https://lore.kernel.org/r/20220609140520.42662-1-marpagan@redhat.com
    Signed-off-by: Xu Yilun <yilun.xu@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/fpga/altera-pr-ip-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
    index be0667968d33..df8671af4a92 100644
    --- a/drivers/fpga/altera-pr-ip-core.c
    +++ b/drivers/fpga/altera-pr-ip-core.c
    @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
    u32 *buffer_32 = (u32 *)buf;
    size_t i = 0;

    - if (count <= 0)
    + if (!count)
    return -EINVAL;

    /* Write out the complete 32-bit chunks */
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:34    [W:4.030 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site