Messages in this thread | | | From | Saravana Kannan <> | Date | Mon, 15 Aug 2022 14:00:57 -0700 | Subject | Re: [PATCH v1 9/9] of: property: Simplify of_link_to_phandle() |
| |
On Mon, Aug 15, 2022 at 3:31 AM Tony Lindgren <tony@atomide.com> wrote: > > * Saravana Kannan <saravanak@google.com> [220813 00:30]: > > On Fri, Aug 12, 2022 at 2:47 AM Tony Lindgren <tony@atomide.com> wrote: > > > > > > Hi, > > > > > > * Saravana Kannan <saravanak@google.com> [220810 05:54]: > > > > The driver core now: > > > > - Has the parent device of a supplier pick up the consumers if the > > > > supplier never has a device created for it. > > > > - Ignores a supplier if the supplier has no parent device and will never > > > > be probed by a driver > > > > > > > > And already prevents creating a device link with the consumer as a > > > > supplier of a parent. > > > > > > > > So, we no longer need to find the "compatible" node of the supplier or > > > > do any other checks in of_link_to_phandle(). We simply need to make sure > > > > that the supplier is available in DT. > > > > > > This patch fixes booting for me, so it should be applied as a fix and > > > tagged with: > > > > > > Fixes: 5a46079a9645 ("PM: domains: Delete usage of driver_deferred_probe_check_state()") > > > > > > If there are dependencies to the other patches in this series, it might > > > make sense to revert commit 5a46079a9645 instead. > > > > Yes, there are dependencies on the rest of the patches in this series. > > For linux-next, I think we should pick up this series once we get more > > Tested-bys. > > > > So if 5a46079a9645 is causing any regression in stable branches, we > > should pick up the revert series [1] instead of this series we are > > replying to. > > Agreed we should apply the reverts in [1] for v6.0-rc series. At least > several generations of the TI 32-bit ARM SoCs are failing to boot > otherwise.
Actually I wasn't clear in my earlier email. I meant to say "releases branches", as in 5.19.xxx and not "stable branches". So for 5.19.xxx we'd pick up these reverts.
And for v6.0-rc if my other patch series [1] fixes the issue, I'd rather apply [1] than this series. Because this series is meant to be temporary (I'll be reverting this in the future).
-Saravana
[1] - https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@google.com/
| |