lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 1143/1157] raw: fix a typo in raw_icmp_error()
    Date
    From: Eric Dumazet <edumazet@google.com>

    commit 97a4d46b1516250d640c1ae0c9e7129d160d6a1c upstream.

    I accidentally broke IPv4 traceroute, by swapping iph->saddr
    and iph->daddr.

    Probably because raw_icmp_error() and raw_v4_input()
    use different order for iph->saddr and iph->daddr.

    Fixes: ba44f8182ec2 ("raw: use more conventional iterators")
    Reported-by: John Sperbeck <jsperbeck@google.com>
    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Link: https://lore.kernel.org/r/20220623193540.2851799-1-edumazet@google.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv4/raw.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ipv4/raw.c
    +++ b/net/ipv4/raw.c
    @@ -278,7 +278,7 @@ void raw_icmp_error(struct sk_buff *skb,
    hlist_nulls_for_each_entry(sk, hnode, hlist, sk_nulls_node) {
    iph = (const struct iphdr *)skb->data;
    if (!raw_v4_match(net, sk, iph->protocol,
    - iph->saddr, iph->daddr, dif, sdif))
    + iph->daddr, iph->saddr, dif, sdif))
    continue;
    raw_err(sk, skb, info);
    }

    \
     
     \ /
      Last update: 2022-08-16 06:58    [W:4.828 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site