lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 1121/1157] ext4: correct max_inline_xattr_value_size computing
    Date
    From: Baokun Li <libaokun1@huawei.com>

    [ Upstream commit c9fd167d57133c5b748d16913c4eabc55e531c73 ]

    If the ext4 inode does not have xattr space, 0 is returned in the
    get_max_inline_xattr_value_size function. Otherwise, the function returns
    a negative value when the inode does not contain EXT4_STATE_XATTR.

    Cc: stable@kernel.org
    Signed-off-by: Baokun Li <libaokun1@huawei.com>
    Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Link: https://lore.kernel.org/r/20220616021358.2504451-4-libaokun1@huawei.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/ext4/inline.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
    index 1fa36cbe09ec..a4fbe825694b 100644
    --- a/fs/ext4/inline.c
    +++ b/fs/ext4/inline.c
    @@ -36,6 +36,9 @@ static int get_max_inline_xattr_value_size(struct inode *inode,
    struct ext4_inode *raw_inode;
    int free, min_offs;

    + if (!EXT4_INODE_HAS_XATTR_SPACE(inode))
    + return 0;
    +
    min_offs = EXT4_SB(inode->i_sb)->s_inode_size -
    EXT4_GOOD_OLD_INODE_SIZE -
    EXT4_I(inode)->i_extra_isize -
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:58    [W:4.042 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site