lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 1117/1157] ext4: update s_overhead_clusters in the superblock during an on-line resize
    Date
    From: Theodore Ts'o <tytso@mit.edu>

    [ Upstream commit de394a86658ffe4e89e5328fd4993abfe41b7435 ]

    When doing an online resize, the on-disk superblock on-disk wasn't
    updated. This means that when the file system is unmounted and
    remounted, and the on-disk overhead value is non-zero, this would
    result in the results of statfs(2) to be incorrect.

    This was partially fixed by Commits 10b01ee92df5 ("ext4: fix overhead
    calculation to account for the reserved gdt blocks"), 85d825dbf489
    ("ext4: force overhead calculation if the s_overhead_cluster makes no
    sense"), and eb7054212eac ("ext4: update the cached overhead value in
    the superblock").

    However, since it was too expensive to forcibly recalculate the
    overhead for bigalloc file systems at every mount, this didn't fix the
    problem for bigalloc file systems. This commit should address the
    problem when resizing file systems with the bigalloc feature enabled.

    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Cc: stable@kernel.org
    Reviewed-by: Andreas Dilger <adilger@dilger.ca>
    Link: https://lore.kernel.org/r/20220629040026.112371-1-tytso@mit.edu
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/ext4/resize.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
    index 8b70a4701293..e5c2713aa11a 100644
    --- a/fs/ext4/resize.c
    +++ b/fs/ext4/resize.c
    @@ -1484,6 +1484,7 @@ static void ext4_update_super(struct super_block *sb,
    * Update the fs overhead information
    */
    ext4_calculate_overhead(sb);
    + es->s_overhead_clusters = cpu_to_le32(sbi->s_overhead);

    if (test_opt(sb, DEBUG))
    printk(KERN_DEBUG "EXT4-fs: added group %u:"
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:55    [W:4.017 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site