lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 1090/1157] btrfs: zoned: disable metadata overcommit for zoned
    Date
    From: Naohiro Aota <naohiro.aota@wdc.com>

    [ Upstream commit 79417d040f4f77b19c701bccc23013b9cdac358d ]

    The metadata overcommit makes the space reservation flexible but it is also
    harmful to active zone tracking. Since we cannot finish a block group from
    the metadata allocation context, we might not activate a new block group
    and might not be able to actually write out the overcommit reservations.

    So, disable metadata overcommit for zoned filesystems. We will ensure
    the reservations are under active_total_bytes in the following patches.

    CC: stable@vger.kernel.org # 5.16+
    Fixes: afba2bc036b0 ("btrfs: zoned: implement active zone tracking")
    Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
    Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/btrfs/space-info.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c
    index 2dd8754cb990..f301149c7597 100644
    --- a/fs/btrfs/space-info.c
    +++ b/fs/btrfs/space-info.c
    @@ -349,7 +349,10 @@ int btrfs_can_overcommit(struct btrfs_fs_info *fs_info,
    return 0;

    used = btrfs_space_info_used(space_info, true);
    - avail = calc_available_free_space(fs_info, space_info, flush);
    + if (btrfs_is_zoned(fs_info) && (space_info->flags & BTRFS_BLOCK_GROUP_METADATA))
    + avail = 0;
    + else
    + avail = calc_available_free_space(fs_info, space_info, flush);

    if (used + bytes < space_info->total_bytes + avail)
    return 1;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:54    [W:4.596 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site