lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 1003/1157] tty: serial: fsl_lpuart: correct the count of break characters
    Date
    From: Sherry Sun <sherry.sun@nxp.com>

    [ Upstream commit 707f816f25590c20e056b3bd4a17ce69b03fe856 ]

    The LPUART can't distinguish between a break signal and a framing error,
    so need to count the break characters if there is a framing error and
    received data is zero instead of the parity error.

    Fixes: 5541a9bacfe5 ("serial: fsl_lpuart: handle break and make sysrq work")
    Reviewed-by: Michael Walle <michael@walle.cc>
    Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
    Link: https://lore.kernel.org/r/20220725050115.12396-1-sherry.sun@nxp.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/fsl_lpuart.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
    index 0d6e62f6bb07..561d6d0b7c94 100644
    --- a/drivers/tty/serial/fsl_lpuart.c
    +++ b/drivers/tty/serial/fsl_lpuart.c
    @@ -990,12 +990,12 @@ static void lpuart32_rxint(struct lpuart_port *sport)

    if (sr & (UARTSTAT_PE | UARTSTAT_OR | UARTSTAT_FE)) {
    if (sr & UARTSTAT_PE) {
    + sport->port.icount.parity++;
    + } else if (sr & UARTSTAT_FE) {
    if (is_break)
    sport->port.icount.brk++;
    else
    - sport->port.icount.parity++;
    - } else if (sr & UARTSTAT_FE) {
    - sport->port.icount.frame++;
    + sport->port.icount.frame++;
    }

    if (sr & UARTSTAT_OR)
    @@ -1010,12 +1010,12 @@ static void lpuart32_rxint(struct lpuart_port *sport)
    sr &= sport->port.read_status_mask;

    if (sr & UARTSTAT_PE) {
    + flg = TTY_PARITY;
    + } else if (sr & UARTSTAT_FE) {
    if (is_break)
    flg = TTY_BREAK;
    else
    - flg = TTY_PARITY;
    - } else if (sr & UARTSTAT_FE) {
    - flg = TTY_FRAME;
    + flg = TTY_FRAME;
    }

    if (sr & UARTSTAT_OR)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:53    [W:4.028 / U:0.916 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site