lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0547/1157] net/mlx5e: Remove WARN_ON when trying to offload an unsupported TLS cipher/version
    Date
    From: Gal Pressman <gal@nvidia.com>

    [ Upstream commit 115d9f95ea7ab780ef315dc356bebba2e07cb731 ]

    The driver reports whether TX/RX TLS device offloads are supported, but
    not which ciphers/versions, these should be handled by returning
    -EOPNOTSUPP when .tls_dev_add() is called.

    Remove the WARN_ON kernel trace when the driver gets a request to
    offload a cipher/version that is not supported as it is expected.

    Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")
    Signed-off-by: Gal Pressman <gal@nvidia.com>
    Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
    Reviewed-by: Maxim Mikityanskiy <maximmi@nvidia.com>
    Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c
    index 814f2a56f633..30a70d139046 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c
    @@ -54,7 +54,7 @@ static int mlx5e_ktls_add(struct net_device *netdev, struct sock *sk,
    struct mlx5_core_dev *mdev = priv->mdev;
    int err;

    - if (WARN_ON(!mlx5e_ktls_type_check(mdev, crypto_info)))
    + if (!mlx5e_ktls_type_check(mdev, crypto_info))
    return -EOPNOTSUPP;

    if (direction == TLS_OFFLOAD_CTX_DIR_TX)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:32    [W:3.686 / U:0.644 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site