lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 1019/1157] tty: serial: qcom-geni-serial: Fix %lu -> %u in print statements
    Date
    From: Douglas Anderson <dianders@chromium.org>

    [ Upstream commit 0fec518018cc5ceffa706370b6e3acbbb1e3c798 ]

    When we multiply an unsigned int by a u32 we still end up with an
    unsigned int. That means we should specify "%u" not "%lu" in the
    format code.

    NOTE: this fix was chosen instead of somehow promoting the value to
    "unsigned long" since the max baud rate from the earlier call to
    uart_get_baud_rate() is 4000000 and the max sampling rate is 32.
    4000000 * 32 = 0x07a12000, not even close to overflowing 32-bits.

    Fixes: c474c775716e ("tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate.")
    Reported-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Douglas Anderson <dianders@chromium.org>
    Link: https://lore.kernel.org/r/20220802132250.1.Iea061e14157a17e114dbe2eca764568a02d6b889@changeid
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/qcom_geni_serial.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
    index f754619451dc..f7c1f1807040 100644
    --- a/drivers/tty/serial/qcom_geni_serial.c
    +++ b/drivers/tty/serial/qcom_geni_serial.c
    @@ -1033,12 +1033,12 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport,
    sampling_rate, &clk_div);
    if (!clk_rate) {
    dev_err(port->se.dev,
    - "Couldn't find suitable clock rate for %lu\n",
    + "Couldn't find suitable clock rate for %u\n",
    baud * sampling_rate);
    goto out_restart_rx;
    }

    - dev_dbg(port->se.dev, "desired_rate-%lu, clk_rate-%lu, clk_div-%u\n",
    + dev_dbg(port->se.dev, "desired_rate-%u, clk_rate-%lu, clk_div-%u\n",
    baud * sampling_rate, clk_rate, clk_div);

    uport->uartclk = clk_rate;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-17 16:27    [W:2.636 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site