Messages in this thread | | | Subject | Re: [PATCH v7 8/9] blk-throttle: cleanup tg_update_disptime() | From | Yu Kuai <> | Date | Wed, 17 Aug 2022 09:38:45 +0800 |
| |
Hi, Tejun!
在 2022/08/17 4:09, Tejun Heo 写道: > On Tue, Aug 02, 2022 at 10:04:14PM +0800, Yu Kuai wrote: >> From: Yu Kuai <yukuai3@huawei.com> >> >> tg_update_disptime() only need to adjust postion for 'tg' in >> 'parent_sq', there is no need to call throtl_enqueue/dequeue_tg(). >> >> Save a little overhead in tg_update_disptime() and prepare to cleanup >> flag 'THROTL_TG_PENDING', there are no functional changes. > > Does this actually help anything? Given that the heavy part of the operation > remains the same, this might not be much of an optimization. Is there even a > microbench that can show the difference?
It's right heavy part remains the same, the patch just remove some unnecessary operations. And I didn't run benchmark to test that yet.
Thanks, Kuai > > Thanks. >
| |