lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0988/1157] watchdog: armada_37xx_wdt: check the return value of devm_ioremap() in armada_37xx_wdt_probe()
    Date
    From: William Dean <williamsukatube@gmail.com>

    [ Upstream commit 2d27e52841092e5831dd41f313028c668d816eb0 ]

    The function devm_ioremap() in armada_37xx_wdt_probe() can fail, so
    its return value should be checked.

    Fixes: 54e3d9b518c8a ("watchdog: Add support for Armada 37xx CPU watchdog")
    Reported-by: Hacash Robot <hacashRobot@santino.com>
    Signed-off-by: William Dean <williamsukatube@gmail.com>
    Reviewed-by: Marek Beh=C3=BAn <kabel@kernel.org>
    Reviewed-by: Guenter Roeck <linux@roeck-us.net>
    Link: https://lore.kernel.org/r/20220722030938.2925156-1-williamsukatube@163.com
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/watchdog/armada_37xx_wdt.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/watchdog/armada_37xx_wdt.c b/drivers/watchdog/armada_37xx_wdt.c
    index 1635f421ef2c..854b1cc723cb 100644
    --- a/drivers/watchdog/armada_37xx_wdt.c
    +++ b/drivers/watchdog/armada_37xx_wdt.c
    @@ -274,6 +274,8 @@ static int armada_37xx_wdt_probe(struct platform_device *pdev)
    if (!res)
    return -ENODEV;
    dev->reg = devm_ioremap(&pdev->dev, res->start, resource_size(res));
    + if (!dev->reg)
    + return -ENOMEM;

    /* init clock */
    dev->clk = devm_clk_get(&pdev->dev, NULL);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:50    [W:4.143 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site