lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH 4/5] kernfs: Replace per-fs rwsem with hashed rwsems.
Hello,

I'm bandwidth constrained right now and can't really shepherd this patchset,
so I'm not gonna ack or nack the series. That said, here are my thoughts
after glancing through it:

* I find the returning-with-rwsem-held interface and usage odd. We return
with locks held all the time, so that part in itself is fine but how it's
used in the proposed patch is pretty alien.

* I don't understand why the topo_mutex is needed. What is its relationship
with rename_lock?

* Can't the double/triple lock helpers loop over the sorted list instead of
if'ing each case?

Thanks.

--
tejun

\
 
 \ /
  Last update: 2022-08-17 00:43    [W:0.042 / U:6.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site