lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0954/1157] ASoC: mt6359: Fix refcount leak bug
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit a8d5df69e2ec702d979f7d04ed519caf8691a032 ]

    In mt6359_parse_dt() and mt6359_accdet_parse_dt(), we should call
    of_node_put() for the reference returned by of_get_child_by_name()
    which has increased the refcount.

    Fixes: 683530285316 ("ASoC: mt6359: fix failed to parse DT properties")
    Fixes: eef07b9e0925 ("ASoC: mediatek: mt6359: add MT6359 accdet jack driver")
    Signed-off-by: Liang He <windhl@126.com>
    Link: https://lore.kernel.org/r/20220713102013.367336-1-windhl@126.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/mt6359-accdet.c | 1 +
    sound/soc/codecs/mt6359.c | 1 +
    2 files changed, 2 insertions(+)

    diff --git a/sound/soc/codecs/mt6359-accdet.c b/sound/soc/codecs/mt6359-accdet.c
    index 6d3d170144a0..c190628e2905 100644
    --- a/sound/soc/codecs/mt6359-accdet.c
    +++ b/sound/soc/codecs/mt6359-accdet.c
    @@ -675,6 +675,7 @@ static int mt6359_accdet_parse_dt(struct mt6359_accdet *priv)
    sizeof(struct three_key_threshold));
    }

    + of_node_put(node);
    dev_warn(priv->dev, "accdet caps=%x\n", priv->caps);

    return 0;
    diff --git a/sound/soc/codecs/mt6359.c b/sound/soc/codecs/mt6359.c
    index 23709b180409..c9a453ce8a2a 100644
    --- a/sound/soc/codecs/mt6359.c
    +++ b/sound/soc/codecs/mt6359.c
    @@ -2778,6 +2778,7 @@ static int mt6359_parse_dt(struct mt6359_priv *priv)

    ret = of_property_read_u32(np, "mediatek,mic-type-2",
    &priv->mux_select[MUX_MIC_TYPE_2]);
    + of_node_put(np);
    if (ret) {
    dev_info(priv->dev,
    "%s() failed to read mic-type-2, use default (%d)\n",
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:47    [W:2.766 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site