lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2 2/7] dt-bindings: net: dsa: mediatek,mt7530: fix reset lines
On Sat, Aug 13, 2022 at 06:44:10PM +0300, Arınç ÜNAL wrote:
> - Fix description of mediatek,mcm. mediatek,mcm is not used on MT7623NI.
> - Add description for reset-gpios.
> - Invalidate reset-gpios if mediatek,mcm is used.
> - Invalidate mediatek,mcm if the compatible device is mediatek,mt7531.
> - Require mediatek,mcm for the described MT7621 SoCs as the compatible
> string is only used for MT7530 which is a part of the multi-chip module.

The commit message should answer 'why is this change needed/wanted?' not
'what changed'. I can read the diff to see what changed.

d>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> .../bindings/net/dsa/mediatek,mt7530.yaml | 31 +++++++++++++++++--
> 1 file changed, 28 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> index edf48e917173..4c99266ce82a 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> @@ -110,11 +110,15 @@ properties:
> mediatek,mcm:
> type: boolean
> description:
> - if defined, indicates that either MT7530 is the part on multi-chip
> - module belong to MT7623A has or the remotely standalone chip as the
> - function MT7623N reference board provided for.
> + Used for MT7621AT, MT7621DAT, MT7621ST and MT7623AI SoCs which the MT7530
> + switch is a part of the multi-chip module.
>
> reset-gpios:
> + description:
> + GPIO to reset the switch. Use this if mediatek,mcm is not used.
> + This property is optional because some boards share the reset line with
> + other components which makes it impossible to probe the switch if the
> + reset line is used.
> maxItems: 1
>
> reset-names:
> @@ -165,6 +169,9 @@ allOf:
> required:
> - mediatek,mcm
> then:
> + properties:
> + reset-gpios: false
> +
> required:
> - resets
> - reset-names
> @@ -182,6 +189,24 @@ allOf:
> - core-supply
> - io-supply
>
> + - if:
> + properties:
> + compatible:
> + items:
> + - const: mediatek,mt7531
> + then:
> + properties:
> + mediatek,mcm: false
> +
> + - if:
> + properties:
> + compatible:
> + items:
> + - const: mediatek,mt7621
> + then:
> + required:
> + - mediatek,mcm
> +
> unevaluatedProperties: false
>
> examples:
> --
> 2.34.1
>
>

\
 
 \ /
  Last update: 2022-08-16 22:54    [W:0.245 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site