lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0890/1157] ASoC: cros_ec_codec: Fix refcount leak in cros_ec_codec_platform_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 0a034d93ee929a9ea89f3fa5f1d8492435b9ee6e ]

    of_parse_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: b6bc07d4360d ("ASoC: cros_ec_codec: support WoV")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
    Reviewed-by: Guenter Roeck <groeck@chromium.org>
    Link: https://lore.kernel.org/r/20220603131043.38907-1-linmq006@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/cros_ec_codec.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
    index 8b0a9c788a26..11e7b3f6d410 100644
    --- a/sound/soc/codecs/cros_ec_codec.c
    +++ b/sound/soc/codecs/cros_ec_codec.c
    @@ -995,6 +995,7 @@ static int cros_ec_codec_platform_probe(struct platform_device *pdev)
    dev_dbg(dev, "ap_shm_phys_addr=%#llx len=%#x\n",
    priv->ap_shm_phys_addr, priv->ap_shm_len);
    }
    + of_node_put(node);
    }
    #endif

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:47    [W:4.130 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site