Messages in this thread | | | Date | Tue, 16 Aug 2022 19:03:21 +0100 | From | Mark Brown <> | Subject | Re: [RFC PATCH 5/6] firmware: arm_scmi: Add raw transmission support |
| |
On Tue, Aug 16, 2022 at 08:24:49AM +0100, Cristian Marussi wrote: > Add SCMI Raw mode support which exposes a userspace interface rooted under > /sys/kernel/debug/scmi_raw.
> Raw mode can be enabled/disabled at runtime via ./scmi_raw/enable. > Once enabled, all the regular SCMI drivers activity is inhibited and a > userspace application can then inject and read back bare SCMI messages > writing and reading to/from ./scmi_raw/message* entries.
Is there a strong reason to have the runtime enable/disable? Given that this is going to be used in special kernel builds rather than something people have as standard it feels like the transition to/from raw mode is opening up a set of extra use cases that wouldn't normally come up for the SCMI drivers (especially if the testing ends up leaving the firmware in a weird state). [unhandled content-type:application/pgp-signature] | |