lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 4/4] dt-bindings: PCI: microchip,pcie-host: fix missing address translation property
    Date
    On 16/08/2022 18:16, Rob Herring wrote:
    >>>> .../devicetree/bindings/pci/microchip,pcie-host.yaml | 11 +++++++++++
    >>>> 1 file changed, 11 insertions(+)
    >>>>
    >>>> diff --git a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
    >>>> index 9b123bcd034c..9ac34b33c4b2 100644
    >>>> --- a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
    >>>> +++ b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
    >>>> @@ -71,6 +71,17 @@ properties:
    >>>> msi-parent:
    >>>> description: MSI controller the device is capable of using.
    >>>>
    >>>> + microchip,axi-m-atr0:
    >>>
    >>> Name is not helping. If it is offset, add such suffix (see
    >>> brcm,iproc-pcie.yaml).
    >>>
    >>> Unfortunately I don't know PCIe good enough to judge whether the
    >>> property makes any sense or some other ranges-style should be used.
    >>
    >> Yup, I think it is similar to that. Except we have 4 tables rather
    >> than one.
    >
    > Looks to me like dma-ranges is the answer.

    Hey Rob,
    Thanks for chiming in. I think what I'll do is:
    - delete the property from the dts, as it should never have been
    there in the first place.
    - resubmit the series without this patch to clear the dtbs_check
    warnings
    - add dma-ranges separately

    Thanks,
    Conor.


    \
     
     \ /
      Last update: 2022-08-16 20:01    [W:7.607 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site