lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0808/1157] usb: gadget: udc: amd5536 depends on HAS_DMA
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit 8097cf2fb3b2205257f1c76f4808e3398d66b6d9 ]

    USB_AMD5536UDC should depend on HAS_DMA since it selects USB_SNP_CORE,
    which depends on HAS_DMA and since 'select' does not follow any
    dependency chains.

    Fixes this kconfig warning:

    WARNING: unmet direct dependencies detected for USB_SNP_CORE
    Depends on [n]: USB_SUPPORT [=y] && USB_GADGET [=y] && (USB_AMD5536UDC [=y] || USB_SNP_UDC_PLAT [=n]) && HAS_DMA [=n]
    Selected by [y]:
    - USB_AMD5536UDC [=y] && USB_SUPPORT [=y] && USB_GADGET [=y] && USB_PCI [=y]

    Fixes: 97b3ffa233b9 ("usb: gadget: udc: amd5536: split core and PCI layer")
    Cc: Raviteja Garimella <raviteja.garimella@broadcom.com>
    Cc: Felipe Balbi <balbi@kernel.org>
    Cc: linux-usb@vger.kernel.org
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Link: https://lore.kernel.org/r/20220709013601.7536-1-rdunlap@infradead.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/gadget/udc/Kconfig | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
    index 69394dc1cdfb..2cdd37be165a 100644
    --- a/drivers/usb/gadget/udc/Kconfig
    +++ b/drivers/usb/gadget/udc/Kconfig
    @@ -311,7 +311,7 @@ source "drivers/usb/gadget/udc/bdc/Kconfig"

    config USB_AMD5536UDC
    tristate "AMD5536 UDC"
    - depends on USB_PCI
    + depends on USB_PCI && HAS_DMA
    select USB_SNP_CORE
    help
    The AMD5536 UDC is part of the AMD Geode CS5536, an x86 southbridge.
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:44    [W:3.656 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site