lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0787/1157] intel_th: msu-sink: Potential dereference of null pointer
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit 82f76a4a720791d889de775b5f7541d601efc8bd ]

    The return value of dma_alloc_coherent() needs to be checked.
    To avoid use of null pointer in sg_set_buf() in case of the failure of
    alloc.

    Fixes: f220df66f676 ("intel_th: msu-sink: An example msu buffer "sink"")
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Link: https://lore.kernel.org/r/20220705082637.59979-3-alexander.shishkin@linux.intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwtracing/intel_th/msu-sink.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/hwtracing/intel_th/msu-sink.c b/drivers/hwtracing/intel_th/msu-sink.c
    index 2c7f5116be12..891b28ea25fe 100644
    --- a/drivers/hwtracing/intel_th/msu-sink.c
    +++ b/drivers/hwtracing/intel_th/msu-sink.c
    @@ -71,6 +71,9 @@ static int msu_sink_alloc_window(void *data, struct sg_table **sgt, size_t size)
    block = dma_alloc_coherent(priv->dev->parent->parent,
    PAGE_SIZE, &sg_dma_address(sg_ptr),
    GFP_KERNEL);
    + if (!block)
    + return -ENOMEM;
    +
    sg_set_buf(sg_ptr, block, PAGE_SIZE);
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:44    [W:4.037 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site