lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/6] mm/hugetlb: fix missing call to restore_reserve_on_error()
    Date
    When huge_add_to_page_cache() fails, the page is freed directly without
    calling restore_reserve_on_error() to restore reserve for newly allocated
    pages not in page cache. Fix this by calling restore_reserve_on_error()
    when huge_add_to_page_cache fails.

    Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
    ---
    mm/hugetlb.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/mm/hugetlb.c b/mm/hugetlb.c
    index ff991e5bdf1f..b69d7808f457 100644
    --- a/mm/hugetlb.c
    +++ b/mm/hugetlb.c
    @@ -5603,6 +5603,7 @@ static vm_fault_t hugetlb_no_page(struct mm_struct *mm,
    if (vma->vm_flags & VM_MAYSHARE) {
    int err = huge_add_to_page_cache(page, mapping, idx);
    if (err) {
    + restore_reserve_on_error(h, vma, haddr, page);
    put_page(page);
    if (err == -EEXIST)
    goto retry;
    --
    2.23.0
    \
     
     \ /
      Last update: 2022-08-16 15:08    [W:4.240 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site