Messages in this thread | | | Date | Mon, 15 Aug 2022 08:07:01 +0200 | From | Marcus Folkesson <> | Subject | Re: [PATCH v5 7/9] dt-bindings: iio: adc: mcp3911: add microchip,data-ready-hiz entry |
| |
On Tue, Aug 09, 2022 at 11:57:19AM +0200, Andy Shevchenko wrote: > On Tue, Aug 9, 2022 at 9:32 AM Marcus Folkesson > <marcus.folkesson@gmail.com> wrote: > > > > The Data Ready Output Pin is either hard wired to work as high > > impedance or push-pull. Make it configurable. > > ... > > > + description: > > + Data Ready Pin Inactive State Control > > + true = The DR pin state is high-impedance when data are NOT ready > > + false = The DR pin state is a logic high when data are NOT ready > > Wouldn't be better to move " when data are NOT ready" to the main > description text: > > Data Ready Pin Inactive State Control when data are NOT ready > > In this case it unloads the list and moves focus from the part of "NOT > ready" to the real part of what you pointed out here -- > "high-impedance" or "high".
I think I will put it as
Data Ready Pin Inactive State Control true = The DR pin state is high-impedance false = The DR pin state is logic high
As "NOT ready" is redundant is it is a "Inactive state control".
> > > -- > With Best Regards, > Andy Shevchenko [unhandled content-type:application/pgp-signature] | |