Messages in this thread | | | From | Alistair Popple <> | Subject | Re: [PATCH v4 1/2] mm/gup.c: Don't pass gup_flags to check_and_migrate_movable_pages() | Date | Mon, 15 Aug 2022 15:52:53 +1000 |
| |
Matthew Wilcox <willy@infradead.org> writes:
> On Fri, Aug 12, 2022 at 11:02:42AM -0700, John Hubbard wrote: >> On 8/12/22 05:57, Matthew Wilcox wrote: >> > On Fri, Aug 12, 2022 at 12:13:08PM +1000, Alistair Popple wrote: >> > > + get_page(&folio->page); >> > > + unpin_user_page(&folio->page); >> > >> > https://lore.kernel.org/linux-mm/YvJddHPZsh7Lwzps@casper.infradead.org/ >> >> The above fix shows up in patch 2/2. I noticed during review that >> it was applied to a different patch than the one you replied to, >> but figured it didn't matter which patch picked up this fix, since >> the problem precedes either patch. > > Oh! I didn't realise patch 2/2 changed the same lines. let me go > and read 2/2.
Oh, and I missed that your original comment was on patch 1/2 not 2/2. Anyway let me know if you think I should move it to the first patch, I don't mind either way.
| |