Messages in this thread | | | From | Aleksey Romanov <> | Subject | Re: [PATCH v1 1/2] zsmalloc: zs_object_copy: add clarifying comment | Date | Mon, 15 Aug 2022 12:32:03 +0000 |
| |
Hi, Sergey.
On Mon, Aug 15, 2022 at 11:52:47AM +0900, Sergey Senozhatsky wrote: > On (22/08/11 18:37), Alexey Romanov wrote: > > @@ -1564,6 +1564,12 @@ static void zs_object_copy(struct size_class *class, unsigned long dst, > > d_off += size; > > d_size -= size; > > > > + /* Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic() calls > > + * must occurs in reverse order of calls to kmap_atomic(). > > + * So, to call kunmap_atomic(s_addr) we should first call kunmap_atomic(d_addr). > > + * For more details see: > > + * https://lore.kernel.org/linux-mm/5512421D.4000603@samsung.com/ > > + */ > > I'd drop the link part, Emails are not documentation, kmap_atomic > is documented in Documentation/mm/highmem
I'll fix it in v2 patchset, but Andrew has already merged v1 patchset into the mm-unstable branch.
-- Thank you, Alexey
| |