lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 1/2] zsmalloc: zs_object_copy: add clarifying comment
Date
Hi, Sergey.

On Mon, Aug 15, 2022 at 11:52:47AM +0900, Sergey Senozhatsky wrote:
> On (22/08/11 18:37), Alexey Romanov wrote:
> > @@ -1564,6 +1564,12 @@ static void zs_object_copy(struct size_class *class, unsigned long dst,
> > d_off += size;
> > d_size -= size;
> >
> > + /* Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic() calls
> > + * must occurs in reverse order of calls to kmap_atomic().
> > + * So, to call kunmap_atomic(s_addr) we should first call kunmap_atomic(d_addr).
> > + * For more details see:
> > + * https://lore.kernel.org/linux-mm/5512421D.4000603@samsung.com/
> > + */
>
> I'd drop the link part, Emails are not documentation, kmap_atomic
> is documented in Documentation/mm/highmem

I'll fix it in v2 patchset, but Andrew has already merged v1 patchset
into the mm-unstable branch.

--
Thank you,
Alexey
\
 
 \ /
  Last update: 2022-08-15 14:33    [W:0.064 / U:0.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site