lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] squashfs: add the mount parameter theads=<single|multi|percpu>
Hi Xiaoming,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v6.0-rc1]
[also build test WARNING on linus/master next-20220815]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Xiaoming-Ni/squashfs-Add-the-mount-parameter-threads/20220815-111318
base: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
config: sparc-randconfig-s042-20220814 (https://download.01.org/0day-ci/archive/20220815/202208151921.Y0vJnA6c-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 12.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/dcb72eaed7732d884148ce37d23442956296d0d6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Xiaoming-Ni/squashfs-Add-the-mount-parameter-threads/20220815-111318
git checkout dcb72eaed7732d884148ce37d23442956296d0d6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sparc SHELL=/bin/bash fs/squashfs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> fs/squashfs/decompressor_multi_percpu.c:85:18: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got void * @@
fs/squashfs/decompressor_multi_percpu.c:85:18: sparse: expected void const [noderef] __percpu *__vpp_verify
fs/squashfs/decompressor_multi_percpu.c:85:18: sparse: got void *
fs/squashfs/decompressor_multi_percpu.c:86:9: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got struct local_lock_t * @@
fs/squashfs/decompressor_multi_percpu.c:86:9: sparse: expected void const [noderef] __percpu *__vpp_verify
fs/squashfs/decompressor_multi_percpu.c:86:9: sparse: got struct local_lock_t *
fs/squashfs/decompressor_multi_percpu.c:91:9: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got struct local_lock_t * @@
fs/squashfs/decompressor_multi_percpu.c:91:9: sparse: expected void const [noderef] __percpu *__vpp_verify
fs/squashfs/decompressor_multi_percpu.c:91:9: sparse: got struct local_lock_t *

vim +85 fs/squashfs/decompressor_multi_percpu.c

d208383d640727 Phillip Lougher 2013-11-18 77
dcb72eaed7732d Xiaoming Ni 2022-08-15 78 static int squashfs_decompress_percpu(struct squashfs_sb_info *msblk, struct bio *bio,
93e72b3c612adc Philippe Liard 2020-06-01 79 int offset, int length, struct squashfs_page_actor *output)
d208383d640727 Phillip Lougher 2013-11-18 80 {
dcb72eaed7732d Xiaoming Ni 2022-08-15 81 struct squashfs_stream_percpu *stream;
fd56200a16c72c Julia Cartwright 2020-05-27 82 int res;
fd56200a16c72c Julia Cartwright 2020-05-27 83
dcb72eaed7732d Xiaoming Ni 2022-08-15 84 preempt_disable();
fd56200a16c72c Julia Cartwright 2020-05-27 @85 stream = this_cpu_ptr(msblk->stream);
dcb72eaed7732d Xiaoming Ni 2022-08-15 86 local_lock(&stream->lock);
fd56200a16c72c Julia Cartwright 2020-05-27 87
93e72b3c612adc Philippe Liard 2020-06-01 88 res = msblk->decompressor->decompress(msblk, stream->stream, bio,
846b730e99518a Phillip Lougher 2013-11-18 89 offset, length, output);
fd56200a16c72c Julia Cartwright 2020-05-27 90
dcb72eaed7732d Xiaoming Ni 2022-08-15 91 local_unlock(&stream->lock);
dcb72eaed7732d Xiaoming Ni 2022-08-15 92 preempt_enable();
d208383d640727 Phillip Lougher 2013-11-18 93
d208383d640727 Phillip Lougher 2013-11-18 94 if (res < 0)
d208383d640727 Phillip Lougher 2013-11-18 95 ERROR("%s decompression failed, data probably corrupt\n",
d208383d640727 Phillip Lougher 2013-11-18 96 msblk->decompressor->name);
d208383d640727 Phillip Lougher 2013-11-18 97
d208383d640727 Phillip Lougher 2013-11-18 98 return res;
d208383d640727 Phillip Lougher 2013-11-18 99 }
d208383d640727 Phillip Lougher 2013-11-18 100

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-08-15 13:19    [W:0.119 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site