lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] PCI: hv: Fix the definiton of vector in hv_compose_msi_msg()
Date
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Monday, August 15, 2022 1:36 PM
> To: Dexuan Cui <decui@microsoft.com>
>
> s/definiton/definition/ in subject
> (only if you have other occasion to repost this)

Thanks, Bjorn! I suppose Wei can help fix this. :-)

> On Mon, Aug 15, 2022 at 11:55:05AM -0700, Dexuan Cui wrote:
> > The local variable 'vector' must be u32 rather than u8: see the
> > struct hv_msi_desc3.
> >
> > 'vector_count' should be u16 rather than u8: see struct hv_msi_desc,
> > hv_msi_desc2 and hv_msi_desc3.
> >
> > Fixes: a2bad844a67b ("PCI: hv: Fix interrupt mapping for multi-MSI")
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
> > Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>
> > Cc: Carl Vanderlip <quic_carlv@quicinc.com>
>
> Looks like Wei has been applying most changes to pci-hyperv.c, so I
> assume the same will happen here.

So I interpret this as an ack for Wei to apply the earlier patch
[PATCH] PCI: hv: Only reuse existing IRTE allocation for Multi-MSI
and this patch.

The two small patches are pure Hyper-V specific changes, so IMO it's
better for them to go through Wei's Hyper-V tree rather than the PCI tree.
(It looks like the PCI folks are too busy right now)

> > ---
> >
> > The patch should be appplied after the earlier patch:
> > [PATCH] PCI: hv: Only reuse existing IRTE allocation for Multi-MSI

\
 
 \ /
  Last update: 2022-08-16 03:39    [W:0.085 / U:0.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site