lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 772/779] drm/meson: Fix refcount leak in meson_encoder_hdmi_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit 7381076809586528e2a812a709e2758916318a99 upstream.

    of_find_device_by_node() takes reference, we should use put_device()
    to release it when not need anymore.
    Add missing put_device() in error path to avoid refcount
    leak.

    Fixes: 0af5e0b41110 ("drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
    Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220511054052.51981-1-linmq006@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/meson/meson_encoder_hdmi.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/gpu/drm/meson/meson_encoder_hdmi.c
    +++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
    @@ -438,8 +438,10 @@ int meson_encoder_hdmi_init(struct meson
    cec_fill_conn_info_from_drm(&conn_info, meson_encoder_hdmi->connector);

    notifier = cec_notifier_conn_register(&pdev->dev, NULL, &conn_info);
    - if (!notifier)
    + if (!notifier) {
    + put_device(&pdev->dev);
    return -ENOMEM;
    + }

    meson_encoder_hdmi->cec_notifier = notifier;
    }

    \
     
     \ /
      Last update: 2022-08-15 22:07    [W:4.141 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site