lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 738/779] dm raid: fix address sanitizer warning in raid_resume
    Date
    From: Mikulas Patocka <mpatocka@redhat.com>

    [ Upstream commit 7dad24db59d2d2803576f2e3645728866a056dab ]

    There is a KASAN warning in raid_resume when running the lvm test
    lvconvert-raid.sh. The reason for the warning is that mddev->raid_disks
    is greater than rs->raid_disks, so the loop touches one entry beyond
    the allocated length.

    Cc: stable@vger.kernel.org
    Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
    Signed-off-by: Mike Snitzer <snitzer@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/md/dm-raid.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
    index 5f7e40c48e47..eba277bb8a1f 100644
    --- a/drivers/md/dm-raid.c
    +++ b/drivers/md/dm-raid.c
    @@ -3824,7 +3824,7 @@ static void attempt_restore_of_faulty_devices(struct raid_set *rs)

    memset(cleared_failed_devices, 0, sizeof(cleared_failed_devices));

    - for (i = 0; i < mddev->raid_disks; i++) {
    + for (i = 0; i < rs->raid_disks; i++) {
    r = &rs->dev[i].rdev;
    /* HM FIXME: enhance journal device recovery processing */
    if (test_bit(Journal, &r->flags))
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:57    [W:4.208 / U:0.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site