lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 616/779] mfd: max77620: Fix refcount leak in max77620_initialise_fps
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 1520669c8255bd637c6b248b2be910e2688d38dd ]

    of_get_child_by_name() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Link: https://lore.kernel.org/r/20220601043222.64441-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mfd/max77620.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c
    index fec2096474ad..a6661e07035b 100644
    --- a/drivers/mfd/max77620.c
    +++ b/drivers/mfd/max77620.c
    @@ -419,9 +419,11 @@ static int max77620_initialise_fps(struct max77620_chip *chip)
    ret = max77620_config_fps(chip, fps_child);
    if (ret < 0) {
    of_node_put(fps_child);
    + of_node_put(fps_np);
    return ret;
    }
    }
    + of_node_put(fps_np);

    config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0;
    ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:39    [W:2.589 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site