lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 542/779] of/fdt: declared return type does not match actual return type
    Date
    From: Xu Qiang <xuqiang36@huawei.com>

    [ Upstream commit 7913145afa51bbed9eaf8e5b4ee55fa9884a71e5 ]

    The commit 649cab56de8e (“of: properly check for error returned
    by fdt_get_name()”) changed the return value type from bool to int,
    but forgot to change the return value simultaneously.

    populate_node was only called in unflatten_dt_nodes, and returns
    with values greater than or equal to 0 were discarded without further
    processing. Considering that return 0 usually indicates success,
    return 0 instead of return true.

    Fixes: 649cab56de8e (“of: properly check for error returned by fdt_get_name()”)
    Signed-off-by: Xu Qiang <xuqiang36@huawei.com>
    Signed-off-by: Rob Herring <robh@kernel.org>
    Link: https://lore.kernel.org/r/20220801120506.11461-2-xuqiang36@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/of/fdt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
    index 59a7a9ee58ef..d245628b15dd 100644
    --- a/drivers/of/fdt.c
    +++ b/drivers/of/fdt.c
    @@ -245,7 +245,7 @@ static int populate_node(const void *blob,
    }

    *pnp = np;
    - return true;
    + return 0;
    }

    static void reverse_nodes(struct device_node *parent)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:29    [W:4.047 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site