lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 496/779] phy: stm32: fix error return in stm32_usbphyc_phy_init
    Date
    From: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

    [ Upstream commit 32b378a9179ae4db61cfc5d502717214e6cd1e1c ]

    Error code is overridden, in case the PLL doesn't lock. So, the USB
    initialization can continue. This leads to a platform freeze.
    This can be avoided by returning proper error code to avoid USB probe
    freezing the platform. It also displays proper errors in log.

    Fixes: 5b1af71280ab ("phy: stm32: rework PLL Lock detection")
    Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
    Link: https://lore.kernel.org/r/20220713133953.595134-1-fabrice.gasnier@foss.st.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/phy/st/phy-stm32-usbphyc.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
    index da05642d3bd4..cd0747ab6267 100644
    --- a/drivers/phy/st/phy-stm32-usbphyc.c
    +++ b/drivers/phy/st/phy-stm32-usbphyc.c
    @@ -279,7 +279,9 @@ static int stm32_usbphyc_phy_init(struct phy *phy)
    return 0;

    pll_disable:
    - return stm32_usbphyc_pll_disable(usbphyc);
    + stm32_usbphyc_pll_disable(usbphyc);
    +
    + return ret;
    }

    static int stm32_usbphyc_phy_exit(struct phy *phy)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:26    [W:2.103 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site